Skip to content

Conversation

@AlmostMatt
Copy link
Contributor

@AlmostMatt AlmostMatt commented Jun 27, 2023

Description

Increase the wait time for FirebaseRemoteConfigTest.TestAddOnConfigUpdateListener from 10s to 30s to reduce test flakiness.

As shown on #1179, the realtime integration test is flaky.

I looked into the logs and all of the failures fail at the point of waiting 10s for the promise to indicate that an updated config has been fetched (example). I looked into a number of other logs and see that even though most runs of this test finish in less than 3 seconds, around 10% of the successes take 5-10 seconds, so the flaky failures are likely just taking slightly longer than normal due to slow network or other delays. 30 seconds should be enough to significantly reduce the flakiness.


Testing

N/A. The change is trivial. Investigated our archive of github test logs to see how often the test takes 10s or almost 10s.


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@AlmostMatt AlmostMatt requested a review from a-maurice June 27, 2023 23:56
@AlmostMatt AlmostMatt added the skip-release-notes Skip release notes check label Jun 27, 2023
@AlmostMatt AlmostMatt enabled auto-merge (squash) June 28, 2023 00:00
@AlmostMatt AlmostMatt merged commit ab2fd00 into main Jun 28, 2023
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Jun 28, 2023
@github-actions
Copy link

github-actions bot commented Jun 28, 2023

✅  Integration test succeeded!

Requested by @AlmostMatt on commit ab2fd00
Last updated: Tue Jun 27 18:55 PDT 2023
View integration test log & download artifacts

@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Jun 28, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jun 28, 2023
@firebase firebase locked and limited conversation to collaborators Jul 29, 2023
@AlmostMatt AlmostMatt deleted the amatt-rc-timeout branch August 1, 2023 19:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

skip-release-notes Skip release notes check tests: succeeded This PR's integration tests succeeded.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants